🏗️✨ Add task to verify package manifests #11
Conversation
DerekNonGeneric
force-pushed
the
master
branch
3 times, most recently
from
0ee6d76 to
409b354
Compare
DerekNonGeneric
force-pushed
the
feat/verify-manifests
branch
3 times, most recently
from
b88fb87 to
074e092
Compare
DerekNonGeneric
force-pushed
the
feat/verify-manifests
branch
8 times, most recently
from
2867f5d to
cc5fc0b
Compare
DerekNonGeneric
force-pushed
the
master
branch
12 times, most recently
from
07351a7 to
c58ee73
Compare
| * Much of the order of these keys follow the order of appearance seen in | ||
| * npm's `man` page. Additionally found [here]. |
There was a problem hiding this comment.
is this verified by CI? seems doable and also would ensure no unknown changes happen
There was a problem hiding this comment.
It's not currently, what CI do you want to use?
- Travis
- GitHub Actions
- Circle
- Something else?
There was a problem hiding this comment.
At the least, by npm test - personally i use travis everywhere, but you could use Github Actions too.
There was a problem hiding this comment.
The GitHub outages are a bit unnerving, but I'm willing to do it.
There was a problem hiding this comment.
@ljharb, for some reason I got the impression that you felt that all of the package.json keys were supposed to be in alphabetical order, but that's not what this PR is doing. I would like to get to the bottom of this… What is the order we should use? lol
DerekNonGeneric
force-pushed
the
feat/verify-manifests
branch
from
1cc3050 to
16dc0eb
Compare
TODO(DerekNonGeneric): actual implementation Helped-by: @ljharb
DerekNonGeneric
force-pushed
the
feat/verify-manifests
branch
from
3a8181d to
4e65d76
Compare
|
I need to keep iterating on this… I guess I will have to keep you posted and let you know once I think I finally have it ideal @ljharb. I still want to ensure CI can check this, but I plan to get all this config published and sharable between projects as dependencies to alleviate the huge mess it makes. Once that is done, I will get it checked for by GitHub Actions. Thanks for the tips! |
DerekNonGeneric
added
the
dependencies
With
package.jsonfiles taking center-stage in several ES module features (not exclusive to packages), and the emergence of npm workspaces, I'd like to ensure consistency and validity amongst them. This is still a WIP, but it currently works pretty well. I had been using it in my monorepo setup, but was able to cleanly separate it. I credit @ljharb for much of the idea as it began as an attempt to solve a problem he brought up on Slack. Hopefully, folks will find this useful and we'd avoid duplicating our efforts here.I've been thinking a bit about the scope of this project and I think one appropriate non-goal would be to depend on engines beyond the main engines of the Node.js toolchain (
node,npm,npx). The thought came to mind when I was thinking about how workspaces and self-referential modules would be interacting together in the same project. I haven't yet read the RFC above, but that would be next.